Skip to content

refactor(auth): use @InternalApi annotation instead of comments#13579

Merged
lqiu96 merged 1 commit into
mainfrom
refactor-internal-api-annotations
Jun 30, 2026
Merged

refactor(auth): use @InternalApi annotation instead of comments#13579
lqiu96 merged 1 commit into
mainfrom
refactor-internal-api-annotations

Conversation

@lqiu96

@lqiu96 lqiu96 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Use the Java SDK @InternalApi instead of comments nested in the javadocs. This follows the convention throughout the Java SDK to denote classes that users should not use.

@lqiu96 lqiu96 requested a review from jinseopkim0 June 29, 2026 21:07
@lqiu96 lqiu96 requested review from a team as code owners June 29, 2026 21:07

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request explicitly marks DefaultMtlsProviderFactory and SecureConnectProvider with the @InternalApi annotation. Additionally, it simplifies the Javadoc comments across several classes, including DefaultMtlsProviderFactory, SecureConnectProvider, X509Provider, and OAuth2Utils, by removing redundant text regarding internal use and backwards compatibility. There are no review comments, so I have no feedback to provide.

@lqiu96 lqiu96 merged commit 91174bd into main Jun 30, 2026
404 of 409 checks passed
@lqiu96 lqiu96 deleted the refactor-internal-api-annotations branch June 30, 2026 14:16
lqiu96 added a commit that referenced this pull request Jun 30, 2026
Use the Java SDK `@InternalApi` instead of comments nested in the
javadocs. This follows the convention throughout the Java SDK to denote
classes that users should not use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants