refactor(auth): use @InternalApi annotation instead of comments#13579
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request explicitly marks DefaultMtlsProviderFactory and SecureConnectProvider with the @InternalApi annotation. Additionally, it simplifies the Javadoc comments across several classes, including DefaultMtlsProviderFactory, SecureConnectProvider, X509Provider, and OAuth2Utils, by removing redundant text regarding internal use and backwards compatibility. There are no review comments, so I have no feedback to provide.
blakeli0
approved these changes
Jun 30, 2026
jinseopkim0
approved these changes
Jun 30, 2026
lqiu96
added a commit
that referenced
this pull request
Jun 30, 2026
Use the Java SDK `@InternalApi` instead of comments nested in the javadocs. This follows the convention throughout the Java SDK to denote classes that users should not use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the Java SDK
@InternalApiinstead of comments nested in the javadocs. This follows the convention throughout the Java SDK to denote classes that users should not use.